Google Testing Blog: TotT: Defeat "Static Cling"

TotT: Defeat "Static Cling"

torsdag, juni 26, 2008

"ConnectionFactory not initialized"staticStatic Clingand weren't careful public class MyObject {
  public int doSomething(int id) {
    return TheirEntity.selectById(id).getSomething();
  }
}TheirEntityimpossibleRepository Pattern interface TheirEntityRepository {
  TheirEntity selectById(int id);
  // other static methods on TheirEntity can be
  // represented here too
}
public class TheirEntityStaticRepository
        implements TheirEntityRepository {
  public TheirEntity selectById(int id) { // non-static
    return TheirEntity.selectById(id); // calls static method
  }
}TheirEntityRepositoryMyObject public class MyObject {
  private final TheirEntityRepository repository;
  public MyEntity(TheirEntityRepository arg) {
    this.repository = arg;
  }
  public int doSomething(int id) {
    return repository.selectById(id).getSomething();
  }
}TheirEntityTheirEntity

4 kommentarer :

Unknown26. juni 2008 kl. 15:35:00 PDT
It is possible to have two classes in Java with the same fully qualified class name, if they are loaded by different class loaders. I don't know how practical it would be to take advantage of that, but at least theoretically it would be possible to mock a static method.
SvarSlett
Svar
Chris27. juni 2008 kl. 02:37:00 PDT
There is also the technique suggested by Michael Feathers in "Working Effectively with Legacy Code" whereby you isolate the offending calls in a handful of protected methods. You then subclass the class under test and stub out these methods.
SvarSlett
Svar
hbchai3. juli 2008 kl. 11:49:00 PDT
You could "mock" the static method with JMockit. However, the pattern suggested here seems like a much better solution.
SvarSlett
Svar
Steve Guidi28. april 2009 kl. 10:14:00 PDT
For .NET programmers, I've written some code that will generate an assembly with the described interface declaration and forwarding implementation. For more information, refer to the testing library http://jolt.codeplex.com.
SvarSlett
Svar

Legg til kommentar

The comments you read and contribute here belong only to the person who posted them. We reserve the right to remove off-topic comments.

Testing Blog

TotT: Defeat "Static Cling"

4 kommentarer :

Labels

Archive

Feed